Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Improve touchpad and mouse support for the Android editor #77497

Merged
merged 1 commit into from May 28, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented May 26, 2023

  • Fix issues with using a touchpad to click, drag, interact with the navigation controls, etc..
  • Fix issues with panning with 2+ fingers
  • Fix issues with using double-tap to magnify on the spatial editor

main version

@lawnjelly
Copy link
Member

Have been testing by building Android editor, it does seem the 3D controls are better after the PR. In particular the controls were getting stuck in a movement before even though I wasn't touching the 3D controls, this seems fixed after the PR.

I'm seeing some kind of graphical corruption in what appears to be the 3D grid, but that's a separate issue unrelated to the input.

Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and from testing of the Android Editor.
Admittedly I'm not an expert on the Android java side, but the logic looks sound.

@akien-mga akien-mga merged commit b717017 into godotengine:3.x May 28, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the improve_keyboard_mouse_support_3x branch May 29, 2023 15:55
m4gr3d added a commit to m4gr3d/godot that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants