Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix trim when importing WAV #78048

Merged
merged 1 commit into from Jun 9, 2023
Merged

[3.x] Fix trim when importing WAV #78048

merged 1 commit into from Jun 9, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jun 9, 2023 •
edited

Backport because the loop mode is in AudioStreamSample in 3.x

4.x version: #75261

@AThousandShips AThousandShips requested a review from a team as a code owner June 9, 2023 13:29
@AThousandShips AThousandShips mentioned this pull request Jun 9, 2023
Merged
@akien-mga akien-mga added bug topic:audio topic:import cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jun 9, 2023
@akien-mga akien-mga added this to the 3.6 milestone Jun 9, 2023
@akien-mga akien-mga merged commit b3396b0 into godotengine:3.x Jun 9, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the wav_trim_3_x branch June 9, 2023 13:40
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:audio topic:import
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AThousandShips @akien-mga