Unnecessary escaping in attributes

[soukicz]

I am trying to migrate templates from Twig to Twital and there is problem with this code:

(autoescaping is on)

<img src="{%if true%}/a/x.jpg{%endif%}">

Expected result:

<img src="/a/x.jpg">

Actual result:

<img src="%2Fa%2Fx.jpg">

I could rewrite code but it would be much more practical if it could be compatible with Twig.

[soukicz]

This could be solved be enabling FullCompatibilityTwigExtension, but that would enable less strict syntax.

[soukicz]

Is is working correctly with ContextAwareEscapingSubscriber disabled

[goetas]

hi! the right syntax for your code should be:

<img t:attr=" true ? src='/a/x.jpg' ">

See http://twital.readthedocs.org/en/latest/tags/attr.html

[goetas]

The syntax used by you should work only with FullCompatibilityTwigExtension enabled. Does it work?

[soukicz]

I realize that, but it would require rewrite large amount of template code before migration and FullCompatibilityTwigExtension enables a lot of others things.

It is also inconsistent:

<img src="{%if true%}/a/x.jpg{%endif%}">
{# output <img src="%2Fa%2Fx.jpg"> #}

<img src="{{ true ? '/a/x.jpg' }}">
{# output <img src="/a/x.jpg"> #}

[goetas]

It make sense, i Will take a look

[soukicz]

The will be probably somewhere in ContextAwareEscapingSubscriber (esapeUrls?) but I can't find specific place.

[goetas]

I'm unable to reproduce the issue (see branch escaping test case I22Test).

Feel free to fork it and create a failing test case.

[goetas]

any news in this?

[goetas]

@Soukiii ping

[soukicz]

I am using this test for my quick&dirty fix:

public function testAttributes() {
        $this->assertHtml('<img src="/a/x.jpg">', '<img src="{{a}}">', ['a' => '/a/x.jpg']);
        $this->assertHtml('<img src="/b/x.jpg">', '<img src="{{ true ? "/b/x.jpg"}}">');
        $this->assertHtml('<img src="/c/x.jpg">', '<img src="{%if true%}/c/x.jpg{%endif%}">');
        $this->assertHtml('<img src="/d/x.jpg">', '<img src="{%if true%}{{a}}{%else%}{{b}}{%endif%}">', ['a' => '/d/x.jpg', 'b' => '/b/x.jpg']);
    }

I will try to look at it later.

[goetas]

added test https://github.com/goetas/twital/commits/master no way to reproduce

[soukicz]

These test were definitely failing with master version which means that you fixed it with some other changes.