Improved compatibility with twig templates #14
Conversation
| '[_TWITAL_[', | ||
| ']_TWITAL_]' | ||
| ); | ||
| protected $placeholders = array(); |
There was a problem hiding this comment.
Store data into a class variable, sounds a little bit strange, and makes this event subscriber not stateless.
State of current template is not stored into a template, but is partially stored into $placeholders variable.
Some future implementation with multiple calls to compiler.pre_load event can't be possible.
I know that this is a "border" case, but i want to hear your opinion.
There was a problem hiding this comment.
I store only Twig expressions that are independent on Twital as same as in https://github.com/arnaud-lb/MtHaml/blob/1.4.0/lib/MtHaml/Filter/Markdown.php
|
Is not my intention to be too strict (closed to changes), but some changes will allow to do things which is really far from http://en.wikipedia.org/wiki/Template_Attribute_Language principles. This changes will make Twital really close to Twig. If a developer want to use syntax like this: <label{% for attrname, attrvalue in label_attr %} {{ attrname }}="{{ attrvalue }}"{% endfor %}>foo</label>i will suggest to use directly Twig. Twital has been created to avoid control structures between tags and attributes thats improve readability. |
|
Why not create an extension called Doing this, the core of Twital can remain tiny and clean. Users that want to use a full compatibility have simply to enable it. $twital>addExtension(new FullCompatibilityTwigExtension());(This feature should be documented...) |
|
@goetas I implemented your great idea. |
| return array( | ||
| // operators | ||
|
|
||
| array('<div>{% if foo > 5 and bar < 8 and bar & 4 %}foo{% endif %}</div>'), |
There was a problem hiding this comment.
Tests starting from line 75 to 87 should stay into CoreNodesTest
There was a problem hiding this comment.
Tests are duplicated.
Added extension which improves compatibility with twig templates
|
Great! |
Fixes: #12, #13