This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Make connection optional for host vars #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ansible_connection cannot be resolved at the time this plugin is run it would set ansible_connection to "ssh". This can lead to undesired behavior. The plugin should not set ansible_connection (or ansible_port) unless the value comes from Vault.
gbevan
added a commit
to gbevan/hashivault_vars
that referenced
this pull request
Jul 7, 2019
… tests to cover. Updated README.
|
pls see #26 |
gbevan
added a commit
that referenced
this pull request
Jul 7, 2019
Reworked #25 with combined use-cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ansible_connection cannot be resolved at the time this plugin is
run it would set ansible_connection to "ssh". This can lead to undesired
behavior. The plugin should not set ansible_connection (or ansible_port)
unless the value comes from Vault.