Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: API reference for all components #247

Open
1 of 2 tasks
thatsamsonkid opened this issue Apr 3, 2024 · 10 comments · May be fixed by #464
Open
1 of 2 tasks

Docs: API reference for all components #247

thatsamsonkid opened this issue Apr 3, 2024 · 10 comments · May be fixed by #464
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@thatsamsonkid
Copy link
Collaborator

Which scope/s are relevant/related to the feature request?

Docs

Information

Need to add documentation to that outlines the api inputs and outputs for all the components in the library

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@thatsamsonkid thatsamsonkid added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 3, 2024
@thatsamsonkid thatsamsonkid self-assigned this Apr 3, 2024
@thatsamsonkid thatsamsonkid changed the title Docs: API Reference for all components Docs: API reference for all components Apr 3, 2024
@jackyshows
Copy link
Contributor

@goetzrobin I can handle that.

Do you already have the list of API references for each component, or should I figure that out myself?
Additionally, do you have any recommendations for the graphics? My plan was to add the section under the "Examples" section, displaying the name of each input and its description in a table, similar to what Material does: https://material.angular.io/components/paginator/api.

@thatsamsonkid
Copy link
Collaborator Author

@jackyshows - Checkout this discussion for some more information on the display piece, #107. Also no api reference to easily look at unfortunately, so you will have to check each component out to figure it out for now. Would definitely appreciate a hand on this. I was originally going to do it but got sidetracked with some other things and just been a little low on time. We can definitely do an initial static documenting of the component API's but one thing I was thinking of if there was a way we could have api reference update dynamically like as part of the build or something. Just some food for thought, we don't necessarily need to figure that out as part of this ticket but just thought I would mention in case you might have any ideas while working on this.

Let me know if I can provide anything else, if not just thumbs up and I'll assign this to you

@jackyshows
Copy link
Contributor

@jackyshows - Checkout this discussion for some more information on the display piece, #107. Also no api reference to easily look at unfortunately, so you will have to check each component out to figure it out for now. Would definitely appreciate a hand on this. I was originally going to do it but got sidetracked with some other things and just been a little low on time. We can definitely do an initial static documenting of the component API's but one thing I was thinking of if there was a way we could have api reference update dynamically like as part of the build or something. Just some food for thought, we don't necessarily need to figure that out as part of this ticket but just thought I would mention in case you might have any ideas while working on this.

Let me know if I can provide anything else, if not just thumbs up and I'll assign this to you

I read your message and the entire discussion. At the moment, I don't know a solution for automatically gathering all the API references. However, I can research and study this topic, as it's something I'd like to do.

In the meantime, I think we can start by building a "static" version. I noticed you've already started creating a mockup API section for testing purposes.

So, the question now is: how do we share the work we're going to do? Should we share a forked repository and commit all the changes there?

@thatsamsonkid
Copy link
Collaborator Author

@jackyshows - you can just start on your own branch in a forked repo. I really did not make much significant changes it was just some quick and dirty changes to see how each option would look roughly. I'm not sure if I still have that branch since it was a while ago but I can check if you really want it but I think you can just start from new.

@jackyshows
Copy link
Contributor

@thatsamsonkid Don't worry about it; I'll start from a new branch. Based on the discussion #107, did I understand correctly that we should follow option B?

@thatsamsonkid
Copy link
Collaborator Author

@thatsamsonkid Don't worry about it; I'll start from a new branch. Based on the discussion #107, did I understand correctly that we should follow option B?

Yes most of us voted for option B, so lets go with that

@thatsamsonkid
Copy link
Collaborator Author

@jackyshows have you made progress on this? Else im considering splitting this to 1 or few components so it's easier to work on.

@IEdiong
Copy link

IEdiong commented Oct 18, 2024

@jackyshows have you made progress on this? Else im considering splitting this to 1 or few components so it's easier to work on.

No response to this yet? @thatsamsonkid
What now?

@thatsamsonkid
Copy link
Collaborator Author

Ok I will unassign this issue for now. I think I will keep it more to confirm when we complete documenting all the components we have and lets create an issue for documenting each component. @IEdiong if you want pick a component you would like to help document and create an issue for it for now. Once we have the initial implementation I will create issues for documenting the rest of the components.

@thatsamsonkid
Copy link
Collaborator Author

I am retaking up this issue. Mainly because I think I got a semi decent implementation for auto generating the api docs from the code so it is not something we need to maintain separately.

@thatsamsonkid thatsamsonkid self-assigned this Nov 9, 2024
@thatsamsonkid thatsamsonkid linked a pull request Nov 9, 2024 that will close this issue
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants