-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zap support for Fiber. #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put some comments.I don't know very much about this logger, sorry if I'm saying something wrong
@Jictyvoo can you check the stuff again -> when you approve it, i will merge it |
I need to recheck benchmarks before merging it. Can you wait a bit? |
sure |
@ReneWerner87 @Jictyvoo I think everything is OK. |
Faster than Fiber's offical logger.
Offical:
Fiberzap:
But i need to decrease allocs/op, B/op and ns/op before the merging it. I need your reviews to fix it :)