add recover config & default recover handler & tests #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReneWerner87
approved these changes
Jul 16, 2023
|
@mstrYoda pls handle this |
I will patch this a few hours later 👍 |
|
@mstrYoda can you add support for StackTrace like current recover middleware, it might be useful for some cases. |
I pushed the changes, added print stack trace to default recover handler. I did not take any config for recover handler, one can just change it at all including stack handler. |
efectn
reviewed
Jul 17, 2023
websocket/websocket.go
Outdated
| // Default recover function is used when nil and writes error message in a response field `error` | ||
| // It prints stack trace to the stderr by default | ||
| // Optional. Default: defaultRecover | ||
| Recover func(*Conn) |
There was a problem hiding this comment.
Should this field be RecoverHandler?
efectn
reviewed
Jul 17, 2023
efectn
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #624
As a default behavior I wrote the error as response message. But it can be changed WDYT about it? @efectn