support disablecache

gofiber · May 19, 2024 · 545a5eb · 545a5eb
1 parent ad70fe6
commit 545a5eb
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/middleware/static/static.go b/middleware/static/static.go
@@ -67,6 +67,7 @@ func New(root string, cfg ...Config) fiber.Handler {
 				Compress:             config.Compress,
 				CompressedFileSuffix: c.App().Config().CompressedFileSuffix,
 				CacheDuration:        config.CacheDuration,
+				SkipCache:            config.CacheDuration < 0,
 				IndexNames:           []string{"index.html"},
 				PathNotFound: func(fctx *fasthttp.RequestCtx) {
 					fctx.Response.SetStatusCode(fiber.StatusNotFound)

diff --git a/middleware/static/static_test.go b/middleware/static/static_test.go
@@ -74,6 +74,7 @@ func Test_Static_Direct(t *testing.T) {
 	body, err = io.ReadAll(resp.Body)
 	require.NoError(t, err)
 	require.Contains(t, string(body), "test_routes")
+	t.Fail()
 }
 
 // go test -run Test_Static_MaxAge
@@ -116,6 +117,41 @@ func Test_Static_Custom_CacheControl(t *testing.T) {
 	require.Equal(t, "", normalResp.Header.Get(fiber.HeaderCacheControl), "CacheControl Control")
 }
 
+func Test_Static_Disable_Cache(t *testing.T) {
+	t.Parallel()
+	app := fiber.New()
+
+	file, err := os.Create("../../.github/test.txt")
+	require.NoError(t, err)
+	_, err = file.WriteString("Hello, World!")
+	require.NoError(t, err)
+
+	// Remove the file even if the test fails
+	defer os.Remove("../../.github/test.txt")
+
+	app.Get("/*", New("../../.github/", Config{
+		CacheDuration: -1,
+	}))
+
+	resp, err := app.Test(httptest.NewRequest(fiber.MethodGet, "/test.txt", nil))
+	require.NoError(t, err, "app.Test(req)")
+	require.Equal(t, "", resp.Header.Get(fiber.HeaderCacheControl), "CacheControl Control")
+
+	body, err := io.ReadAll(resp.Body)
+	require.NoError(t, err)
+	require.Contains(t, string(body), "Hello, World!")
+
+	require.NoError(t, os.Remove("../../.github/test.txt"))
+
+	resp, err = app.Test(httptest.NewRequest(fiber.MethodGet, "/test.txt", nil))
+	require.NoError(t, err, "app.Test(req)")
+	require.Equal(t, "", resp.Header.Get(fiber.HeaderCacheControl), "CacheControl Control")
+
+	body, err = io.ReadAll(resp.Body)
+	require.NoError(t, err)
+	require.Equal(t, string(body), "Cannot GET /test.txt")
+}
+
 // go test -run Test_Static_Download
 func Test_Static_Download(t *testing.T) {
 	t.Parallel()