Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: bind support for render #1754

Merged
merged 13 commits into from Feb 12, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Feb 6, 2022

Like #1604 but backward-compatible.

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

@efectn Looks good, but can we outsource some of the loops in sub functions? The binding and local vars stuff maybe

And don't forget the documentation.

@efectn efectn mentioned this pull request Feb 6, 2022
@efectn
Copy link
Member Author

efectn commented Feb 6, 2022

@efectn Looks good, but can we outsource some of the loops in sub functions? The binding and local vars stuff maybe

And don't forget the documentation.

done

ctx.go Outdated Show resolved Hide resolved
ctx.go Outdated Show resolved Hide resolved
efectn and others added 5 commits Feb 12, 2022
Co-authored-by: hi019 <65871571+hi019@users.noreply.github.com>
- improve performance
ctx.go Outdated Show resolved Hide resolved
ctx.go Outdated Show resolved Hide resolved
ctx.go Show resolved Hide resolved
ctx.go Outdated Show resolved Hide resolved
@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 12, 2022

after the last performance adjustments
image
image
image

@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 12, 2022

master:
image

@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 12, 2022

5344d3a
image
better overview with the test template engine, due to less allocations within the render process

@ReneWerner87 ReneWerner87 merged commit 937713e into gofiber:master Feb 12, 2022
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants