Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on SIMD by default in cmake config #383

Closed
James-Mart opened this issue Apr 10, 2023 · 2 comments
Closed

Turn on SIMD by default in cmake config #383

James-Mart opened this issue Apr 10, 2023 · 2 comments
Assignees
@swatanabe

Comments

@James-Mart
Copy link
Member

No description provided.

@swatanabe
Copy link
Collaborator

clang makes this needlessly difficult:

  • clang runs wasm-opt if it is $PATH. There is no way to disable it or modify the invocation
  • wasm-opt uses the target_features section to determine what features (beyond MVP) the wasm uses. If the wasm contains other instructions, it will fail
  • --strip-all causes the target_features section to be removed before wasm-opt is run

@James-Mart
Copy link
Member Author

Seems like --strip-all is the problem, then. Can we just use --strip-debug or are there other considerable space savings that --strip-all provides? Or some deeper reason for strip-all?

swatanabe added a commit that referenced this issue Jun 12, 2023
@swatanabe
Merge pull request #429 from gofractally/simd-cmake
44ba3fa 
Add simd to the default cmake toolchain. Fixes #383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swatanabe swatanabe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swatanabe @James-Mart