Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAuthedTransaction refactored to CommonSys #310

Merged
merged 1 commit into from
Feb 20, 2023
Merged

GetAuthedTransaction refactored to CommonSys #310

merged 1 commit into from
Feb 20, 2023

Conversation

sparkplug0025
Copy link
Contributor

Refactored as in #289

The only missing part is refactoring out the KeyStore to the new KeyVault applet (still TBD).

@James-Mart
Copy link
Member

The Ubuntu 22.04 failure appears to have been a failure to download a third-party resource (iframeresizer.contentwindow).

2023-02-16T12:56:52.0532894Z [ 23%] Performing download step (download and verify) for 'iframeResizer'
2023-02-16T12:56:52.0625596Z -- Downloading...
2023-02-16T12:56:52.0626153Z    dst='/home/runner/work/psibase/psibase/services/user/CommonSys/common/thirdParty/src/iframeResizer.js'
2023-02-16T12:56:52.0626544Z    timeout='none'
2023-02-16T12:56:52.0626789Z    inactivity timeout='none'
2023-02-16T12:56:52.0631916Z -- Using src='https://unpkg.com/iframe-resizer@4.3.1/js/iframeResizer.js'
2023-02-16T12:56:52.1175179Z -- Downloading... done
2023-02-16T12:56:52.1485180Z [ 24%] No update step for 'iframeResizer'
2023-02-16T12:56:52.1746862Z [ 24%] No patch step for 'iframeResizer'
2023-02-16T12:56:52.1996841Z [ 24%] No configure step for 'iframeResizer'
2023-02-16T12:56:52.2247134Z [ 24%] No build step for 'iframeResizer'
2023-02-16T12:56:52.2511048Z [ 24%] No install step for 'iframeResizer'
2023-02-16T12:56:52.2749598Z [ 25%] Completed 'iframeResizer'
2023-02-16T12:56:52.3058716Z [ 25%] Built target iframeResizer
2023-02-16T12:56:52.3241985Z [ 25%] Creating directories for 'iframeResizerContent'
2023-02-16T12:56:52.3913300Z [ 25%] Performing download step (download and verify) for 'iframeResizerContent'
2023-02-16T12:56:52.4006741Z -- Downloading...
2023-02-16T12:56:52.4007402Z    dst='/home/runner/work/psibase/psibase/services/user/CommonSys/common/thirdParty/src/iframeResizer.contentWindow.js'
2023-02-16T12:56:52.4008079Z    timeout='none'
2023-02-16T12:56:52.4008330Z    inactivity timeout='none'
2023-02-16T12:56:52.4013884Z -- Using src='https://unpkg.com/iframe-resizer@4.3.1/js/iframeResizer.contentWindow.js'
2023-02-16T12:56:52.4894142Z CMake Error at iframeResizerContent-stamp/download-iframeResizerContent.cmake:170 (message):
2023-02-16T12:56:52.4894632Z   Each download failed!
2023-02-16T12:56:52.4894773Z 
2023-02-16T12:56:52.4895144Z     error: downloading 'https://unpkg.com/iframe-resizer@4.3.1/js/iframeResizer.contentWindow.js' failed
2023-02-16T12:56:52.4895489Z           status_code: 22
2023-02-16T12:56:52.4895755Z           status_string: "HTTP response code said error"
2023-02-16T12:56:52.4895996Z           log:
2023-02-16T12:56:52.4896506Z           --- LOG BEGIN ---
2023-02-16T12:56:52.4896742Z             Trying 104.16.124.175:443...
2023-02-16T12:56:52.4896884Z 
2023-02-16T12:56:52.4897031Z   Connected to unpkg.com (104.16.124.175) port 443 (#0)
2023-02-16T12:56:52.4897196Z 
2023-02-16T12:56:52.4897269Z   ALPN, offering h2
2023-02-16T12:56:52.4897398Z 
2023-02-16T12:56:52.4897492Z   ALPN, offering http/1.1
2023-02-16T12:56:52.4897629Z 
2023-02-16T12:56:52.4897765Z   TLSv1.0 (OUT), TLS header, Certificate Status (22):
2023-02-16T12:56:52.4897938Z 
2023-02-16T12:56:52.4898019Z   [5 bytes data]
2023-02-16T12:56:52.4898128Z 
2023-02-16T12:56:52.4898257Z   TLSv1.3 (OUT), TLS handshake, Client hello (1):
2023-02-16T12:56:52.4898421Z 
2023-02-16T12:56:52.4898506Z   [512 bytes data]
2023-02-16T12:56:52.4898629Z 
2023-02-16T12:56:52.4898761Z   TLSv1.2 (IN), TLS header, Certificate Status (22):
2023-02-16T12:56:52.4898929Z 
2023-02-16T12:56:52.4899015Z   [5 bytes data]
2023-02-16T12:56:52.4899122Z 
2023-02-16T12:56:52.4899246Z   TLSv1.3 (IN), TLS handshake, Server hello (2):
2023-02-16T12:56:52.4899409Z 
2023-02-16T12:56:52.4899493Z   [122 bytes data]
2023-02-16T12:56:52.4899616Z 
2023-02-16T12:56:52.4899736Z   TLSv1.2 (IN), TLS header, Finished (20):
2023-02-16T12:56:52.4899892Z 
2023-02-16T12:56:52.4899959Z   [5 bytes data]
2023-02-16T12:56:52.4900079Z 
2023-02-16T12:56:52.4900211Z   TLSv1.2 (IN), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4900383Z 
2023-02-16T12:56:52.4900467Z   [5 bytes data]
2023-02-16T12:56:52.4900588Z 
2023-02-16T12:56:52.4900667Z   [1 bytes data]
2023-02-16T12:56:52.4900772Z 
2023-02-16T12:56:52.4900913Z   TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
2023-02-16T12:56:52.4901090Z 
2023-02-16T12:56:52.4901169Z   [19 bytes data]
2023-02-16T12:56:52.4901291Z 
2023-02-16T12:56:52.4901413Z   TLSv1.3 (IN), TLS handshake, Certificate (11):
2023-02-16T12:56:52.4901574Z 
2023-02-16T12:56:52.4901641Z   [2328 bytes data]
2023-02-16T12:56:52.4901764Z 
2023-02-16T12:56:52.4901888Z   TLSv1.3 (IN), TLS handshake, CERT verify (15):
2023-02-16T12:56:52.4902047Z 
2023-02-16T12:56:52.4902128Z   [78 bytes data]
2023-02-16T12:56:52.4902254Z 
2023-02-16T12:56:52.4902374Z   TLSv1.3 (IN), TLS handshake, Finished (20):
2023-02-16T12:56:52.4902524Z 
2023-02-16T12:56:52.4902605Z   [52 bytes data]
2023-02-16T12:56:52.4902724Z 
2023-02-16T12:56:52.4902838Z   TLSv1.2 (OUT), TLS header, Finished (20):
2023-02-16T12:56:52.4902992Z 
2023-02-16T12:56:52.4930828Z   [5 bytes data]
2023-02-16T12:56:52.4931002Z 
2023-02-16T12:56:52.4939040Z   TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
2023-02-16T12:56:52.4939225Z 
2023-02-16T12:56:52.4949137Z   [1 bytes data]
2023-02-16T12:56:52.4949279Z 
2023-02-16T12:56:52.4949436Z   TLSv1.2 (OUT), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4949608Z 
2023-02-16T12:56:52.4949691Z   [5 bytes data]
2023-02-16T12:56:52.4949816Z 
2023-02-16T12:56:52.4949898Z   [1 bytes data]
2023-02-16T12:56:52.4950020Z 
2023-02-16T12:56:52.4950155Z   TLSv1.3 (OUT), TLS handshake, Finished (20):
2023-02-16T12:56:52.4950320Z 
2023-02-16T12:56:52.4950386Z   [52 bytes data]
2023-02-16T12:56:52.4950511Z 
2023-02-16T12:56:52.4950647Z   SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
2023-02-16T12:56:52.4951022Z 
2023-02-16T12:56:52.4951132Z   ALPN, server accepted to use h2
2023-02-16T12:56:52.4951282Z 
2023-02-16T12:56:52.4951375Z   Server certificate:
2023-02-16T12:56:52.4951512Z 
2023-02-16T12:56:52.4951701Z    subject: C=US; ST=California; L=San Francisco; O=Cloudflare, Inc.; CN=sni.cloudflaressl.com
2023-02-16T12:56:52.4952026Z    start date: Jun  1 00:00:00 2022 GMT
2023-02-16T12:56:52.4952274Z    expire date: Jun  1 23:59:59 2023 GMT
2023-02-16T12:56:52.4952804Z    subjectAltName: host "unpkg.com" matched cert's "unpkg.com"
2023-02-16T12:56:52.4953189Z    issuer: C=US; O=Cloudflare, Inc.; CN=Cloudflare Inc ECC CA-3
2023-02-16T12:56:52.4953565Z    SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
2023-02-16T12:56:52.4953792Z 
2023-02-16T12:56:52.4954012Z   Using HTTP2, server supports multiplexing
2023-02-16T12:56:52.4954183Z 
2023-02-16T12:56:52.4954296Z   Connection state changed (HTTP/2 confirmed)
2023-02-16T12:56:52.4954464Z 
2023-02-16T12:56:52.4954634Z   Copying HTTP/2 data in stream buffer to connection buffer after upgrade:
2023-02-16T12:56:52.4954905Z   len=0
2023-02-16T12:56:52.4955018Z 
2023-02-16T12:56:52.4955158Z   TLSv1.2 (OUT), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4955316Z 
2023-02-16T12:56:52.4955395Z   [5 bytes data]
2023-02-16T12:56:52.4955517Z 
2023-02-16T12:56:52.4955596Z   [1 bytes data]
2023-02-16T12:56:52.4955724Z 
2023-02-16T12:56:52.4955863Z   TLSv1.2 (OUT), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4956032Z 
2023-02-16T12:56:52.4956098Z   [5 bytes data]
2023-02-16T12:56:52.4956218Z 
2023-02-16T12:56:52.4956314Z   [1 bytes data]
2023-02-16T12:56:52.4956432Z 
2023-02-16T12:56:52.4956562Z   TLSv1.2 (OUT), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4956730Z 
2023-02-16T12:56:52.4956812Z   [5 bytes data]
2023-02-16T12:56:52.4956920Z 
2023-02-16T12:56:52.4956996Z   [1 bytes data]
2023-02-16T12:56:52.4957114Z 
2023-02-16T12:56:52.4957240Z   Using Stream ID: 1 (easy handle 0x5598aef24850)
2023-02-16T12:56:52.4957409Z 
2023-02-16T12:56:52.4957541Z   TLSv1.2 (OUT), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4957706Z 
2023-02-16T12:56:52.4957772Z   [5 bytes data]
2023-02-16T12:56:52.4957890Z 
2023-02-16T12:56:52.4957969Z   [1 bytes data]
2023-02-16T12:56:52.4958087Z 
2023-02-16T12:56:52.4958498Z   GET /iframe-resizer@4.3.1/js/iframeResizer.contentWindow.js HTTP/2
2023-02-16T12:56:52.4958715Z 
2023-02-16T12:56:52.4958799Z   Host: unpkg.com
2023-02-16T12:56:52.4958909Z 
2023-02-16T12:56:52.4959044Z   user-agent: curl/7.81.0
2023-02-16T12:56:52.4959182Z 
2023-02-16T12:56:52.4959261Z   accept: */*
2023-02-16T12:56:52.4959380Z 
2023-02-16T12:56:52.4959451Z   
2023-02-16T12:56:52.4959560Z 
2023-02-16T12:56:52.4959676Z   TLSv1.2 (IN), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4959851Z 
2023-02-16T12:56:52.4959929Z   [5 bytes data]
2023-02-16T12:56:52.4960049Z 
2023-02-16T12:56:52.4960128Z   [1 bytes data]
2023-02-16T12:56:52.4960248Z 
2023-02-16T12:56:52.4960380Z   TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
2023-02-16T12:56:52.4960537Z 
2023-02-16T12:56:52.4960615Z   [230 bytes data]
2023-02-16T12:56:52.4960735Z 
2023-02-16T12:56:52.4960864Z   TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
2023-02-16T12:56:52.4961033Z 
2023-02-16T12:56:52.4961111Z   [230 bytes data]
2023-02-16T12:56:52.4961230Z 
2023-02-16T12:56:52.4961328Z   old SSL session ID is stale, removing
2023-02-16T12:56:52.4961482Z 
2023-02-16T12:56:52.4961613Z   TLSv1.2 (IN), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4961781Z 
2023-02-16T12:56:52.4961859Z   [5 bytes data]
2023-02-16T12:56:52.4961977Z 
2023-02-16T12:56:52.4962054Z   [1 bytes data]
2023-02-16T12:56:52.4962160Z 
2023-02-16T12:56:52.4962303Z   Connection state changed (MAX_CONCURRENT_STREAMS == 256)!
2023-02-16T12:56:52.4962483Z 
2023-02-16T12:56:52.4962616Z   TLSv1.2 (OUT), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4962783Z 
2023-02-16T12:56:52.4962859Z   [5 bytes data]
2023-02-16T12:56:52.4963074Z 
2023-02-16T12:56:52.4963151Z   [1 bytes data]
2023-02-16T12:56:52.4963256Z 
2023-02-16T12:56:52.4963385Z   TLSv1.2 (IN), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4963549Z 
2023-02-16T12:56:52.4963628Z   [5 bytes data]
2023-02-16T12:56:52.4963747Z 
2023-02-16T12:56:52.4963825Z   [1 bytes data]
2023-02-16T12:56:52.4963942Z 
2023-02-16T12:56:52.4964055Z   TLSv1.2 (IN), TLS header, Supplemental data (23):
2023-02-16T12:56:52.4964218Z 
2023-02-16T12:56:52.4964295Z   [5 bytes data]
2023-02-16T12:56:52.4964416Z 
2023-02-16T12:56:52.4964494Z   [1 bytes data]
2023-02-16T12:56:52.4964611Z 
2023-02-16T12:56:52.4964691Z   HTTP/2 520 
2023-02-16T12:56:52.4964797Z 
2023-02-16T12:56:52.4964896Z   date: Thu, 16 Feb 2023 12:56:52 GMT
2023-02-16T12:56:52.4965038Z 
2023-02-16T12:56:52.4965428Z   content-length: 0
2023-02-16T12:56:52.4965994Z 
2023-02-16T12:56:52.4966326Z   cache-control: no-store, no-cache
2023-02-16T12:56:52.4966495Z 
2023-02-16T12:56:52.4966617Z   cf-cache-status: MISS
2023-02-16T12:56:52.4966767Z 
2023-02-16T12:56:52.4967047Z   strict-transport-security: max-age=31536000; includeSubDomains; preload
2023-02-16T12:56:52.4967274Z 
2023-02-16T12:56:52.4967433Z   x-content-type-options: nosniff
2023-02-16T12:56:52.4967593Z 
2023-02-16T12:56:52.4967680Z   server: cloudflare
2023-02-16T12:56:52.4967797Z 
2023-02-16T12:56:52.4967945Z   cf-ray: 79a6721ff8d03910-IAD
2023-02-16T12:56:52.4968083Z 
2023-02-16T12:56:52.4968196Z   The requested URL returned error: 520
2023-02-16T12:56:52.4968353Z 
2023-02-16T12:56:52.4968451Z   stopped the pause stream!
2023-02-16T12:56:52.4968593Z 
2023-02-16T12:56:52.4968703Z   Connection #0 to host unpkg.com left intact
2023-02-16T12:56:52.4968867Z 
2023-02-16T12:56:52.4968935Z   
2023-02-16T12:56:52.4969040Z 
2023-02-16T12:56:52.4969162Z           --- LOG END ---
2023-02-16T12:56:52.4969361Z           
2023-02-16T12:56:52.4969522Z     
2023-02-16T12:56:52.4969628Z 
2023-02-16T12:56:52.4969633Z 
2023-02-16T12:56:52.4970257Z make[5]: *** [services/user/CommonSys/CMakeFiles/iframeResizerContent.dir/build.make:98: /home/runner/work/psibase/psibase/services/user/CommonSys/common/thirdParty/src/iframeResizerContent-stamp/iframeResizerContent-download] Error 1
2023-02-16T12:56:52.4971558Z make[4]: *** [CMakeFiles/Makefile2:2432: services/user/CommonSys/CMakeFiles/iframeResizerContent.dir/all] Error 2
2023-02-16T12:56:52.4981012Z make[3]: *** [Makefile:146: all] Error 2
2023-02-16T12:56:52.4996053Z make[2]: *** [CMakeFiles/wasm-install.dir/build.make:81: wasm-prefix/src/wasm-stamp/wasm-build] Error 2
2023-02-16T12:56:52.5010195Z make[1]: *** [CMakeFiles/Makefile2:587: CMakeFiles/wasm-install.dir/all] Error 2
2023-02-16T12:56:52.5016790Z make[1]: *** Waiting for unfinished jobs....

But the same download works fine for me right now, and worked during ubuntu 18.04, and ubuntu 20.04.
I will just try to retrigger the build.

@Velua
Copy link
Contributor

Velua commented Feb 20, 2023

Looks good!

@Velua Velua merged commit a497406 into sparkplug0025/getclaim Feb 20, 2023
Velua added a commit that referenced this pull request Feb 28, 2023
@sparkplug0025 @Velua
New sign trx flow (#303)
039c392 
* add psiboard applet

* return empty array on failure

* format import

* remove lock file

* add carrying of token query param

* New sign trx flow

* wip with invite-sys

* Invite sys working flow

* also handle accept

* add addAccounts and getAccounts query

* add accepting accounts

* key fetching

* add query

* add query fix and error handling

* add return

* GetAuthedTransaction refactored to CommonSys

* GetAuthedTransaction refactored to CommonSys (#310)

* remove stale console logs

* add early function return in case of no actions

* remove log

---------

Co-authored-by: John Williamson <johnjwilliamson@live.com>
@sparkplug0025 sparkplug0025 deleted the sparkplug0025/getclaim-refactor1 branch January 5, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velua Velua Velua approved these changes

@James-Mart James-Mart Awaiting requested review from James-Mart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sparkplug0025 @James-Mart @Velua