Put the wasms required to validate block signatures in the block header #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The services need to be updated on setCode to maintain correct invariants. It's better to keep all the tracking in setCode, especially since automatic deduction of services in setProducers misses services called indirectly. - Update psibase, DefaultTestChain, and test_util.cpp to set the new flag on verifyec-sys. - Move CodeRow to nativeConstrained - Allow writes to nativeConstrained to trigger state updates (used to track changes to the set of header auth services) - Allow fracpack to work with psio::input_stream, be adding an implicit conversion to std::span.
…header services at the end of the previous block.
James-Mart
reviewed
Apr 13, 2023
| revision = systemContext->sharedDatabase.emptyRevision(); | ||
| if (auto status = db.kvGet<StatusRow>(StatusRow::db, StatusRow::key())) | ||
| { | ||
| Database dst{systemContext->sharedDatabase, revision}; |
There was a problem hiding this comment.
Why don't you start a write session before updating the db here?
There was a problem hiding this comment.
The test case doesn't catch it because it only loads an empty database
James-Mart
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.