Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve localhost detection #393

Conversation

James-Mart
Copy link
Member

No description provided.

@James-Mart James-Mart linked an issue Apr 26, 2023 that may be closed by this pull request
@James-Mart James-Mart marked this pull request as ready for review April 28, 2023 19:54
@James-Mart
Copy link
Member Author

James-Mart commented May 1, 2023

Regexes should now cover:

    localhost
    localhost:port
    page.localhost
    page.localhost:port

    127.0.0.1
    127.0.0.1:port
    page.127.0.0.1.sslip.io
    page.127.0.0.1.sslip.io:port

    [::1]
    [::1]:port
    page.--1.sslip.io
    page.--1.sslip.io:port

Copy link
Collaborator

@swatanabe swatanabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to complain that this matches localhost42, but a quick look at my /etc/hosts shows that that may be a good thing:

127.0.0.1   localhost localhost.localdomain localhost4 localhost4.localdomain4
::1         localhost localhost.localdomain localhost6 localhost6.localdomain6

@James-Mart James-Mart merged commit 020de86 into main May 1, 2023
@James-Mart James-Mart deleted the 392-admin-service-dashboards-page-needs-better-localhost-detection branch May 1, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin service - Dashboards page needs better localhost detection
2 participants