Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove print.hpp. #398

Merged
merged 3 commits into from
May 5, 2023
Merged

Remove print.hpp. #398

merged 3 commits into from
May 5, 2023

Conversation

swatanabe
Copy link
Collaborator

Use printf instead

  • It actually works
  • It's far more generic
  • We don't need to document it because it's part of the standard library

@swatanabe swatanabe requested a review from James-Mart May 2, 2023 14:34
@swatanabe
Copy link
Collaborator Author

There's still a corresponding print.cpp

@James-Mart
Copy link
Member

There's still a corresponding print.cpp

That should be deleted?

@swatanabe
Copy link
Collaborator Author

There's still a corresponding print.cpp

That should be deleted?

yes

@swatanabe swatanabe merged commit 597cfc1 into main May 5, 2023
@swatanabe swatanabe deleted the remove-print branch May 5, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Mart James-Mart James-Mart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swatanabe @James-Mart