Fix issues found by linter. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes name of variable which does not follow Go convention (minor). Fixes bug where error shadowing causes a hardware address get error to be ignored (major). Signed-off-by: Jaden Weiss <jadr2ddude@gmail.com>
Pull Request Test Coverage Report for Build 21
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 21
💛 - Coveralls |
theckman
approved these changes
Jul 14, 2018
theckman
added a commit
that referenced
this pull request
Jul 14, 2018
Fix issues found by linter. Signed-off-by: Tim Heckman <t@heckman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes name of variable which does not follow Go convention (minor).
Fixes bug where error shadowing causes a hardware address get error to be ignored (major).