-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support braced hashlike on FromString as documented. #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for @theckman to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjamie can you take a look at the coveralls report, and see if the tests can be tweaked to include the lines it claims aren't tested?
It seems like codec.go
is the one it's not happy with:
@theckman I think this isn't a big deal. Some of the things missing were not covered before, and will be covered by my larger testing overhaul PR, which I can send soon. The relevant new code paths introduced by this patch are covered, so I think it's fine to merge it as-is. Your call. |
I can submit a change to cover the FromBytesOrNil and FromStringOrNil success cases. The default switch case in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjamie thank you for the extra effort to get the test coverage back up! That looks awesome!
While I'd generally prefer this as a single commit, I'll merge with the two commits attached.
Support braced hashlike on FromString as documented. Signed-off-by: Tim Heckman <t@heckman.io>
Fix #13.