Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove named return values #25

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Remove named return values #25

merged 1 commit into from
Jul 18, 2018

Conversation

zerkms
Copy link
Member

@zerkms zerkms commented Jul 17, 2018

As per the #23 poll I removed the named return values, which happen to exist only in a single file.

@coveralls
Copy link

coveralls commented Jul 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 74

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 98.438%
Totals Coverage Status
Change from base Build 73: -0.005%
Covered Lines: 315
Relevant Lines: 320
💛 - Coveralls

theckman
theckman approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@theckman theckman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 👍
Also we'll ignore @coveralls.

@zerkms zerkms merged commit 87edc3e into gofrs:master Jul 18, 2018
@zerkms zerkms deleted the NO_NAMED_RETURNS branch July 18, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theckman theckman theckman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerkms @coveralls @theckman