Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: ensure reads from g.rand are not short #7

Merged
merged 1 commit into from
Jul 13, 2018
Merged

generator: ensure reads from g.rand are not short #7

merged 1 commit into from
Jul 13, 2018

Conversation

acln0
Copy link
Member

@acln0 acln0 commented Jul 13, 2018

Use io.ReadFull to read data from g.rand instead of a single Read call.

@acln0
generator: ensure reads from g.rand are not short
a4caae7 
Use io.ReadFull to read data from g.rand instead of a single Read call.
@theckman theckman added the blocked This PR is blocked on another issue or PR label Jul 13, 2018
@theckman
Copy link
Member

@acln0 it's likely I'll need you to rebase this branch once #3 is merged-in. #3 itself is blocked on #6, which has outstanding feedback. Will ping you once #6 and #3 are done.

@acln0
Copy link
Member Author

acln0 commented Jul 13, 2018

I didn't touch the test code in view of #3, which is good enough, I think. If you still need me to rebase after #3 is done, please ping.

@theckman
Copy link
Member

@acln0 ignore me, Travis tests on the merge branch. I'll rerun it once the merge is done.

@cameracker cameracker mentioned this pull request Jul 13, 2018
Merged
@theckman
Copy link
Member

Recycling PR to get a fresh CI run.

@theckman theckman closed this Jul 13, 2018
@theckman theckman reopened this Jul 13, 2018
@theckman theckman merged commit a4caae7 into gofrs:master Jul 13, 2018
theckman added a commit that referenced this pull request Jul 13, 2018
@theckman
Merge pull request #7 from acln0/rand-read
a78f1bd 
generator: ensure reads from g.rand are not short

Signed-off-by: Tim Heckman <theckman@netflix.com>
@acln0 acln0 deleted the rand-read branch July 13, 2018 21:53
@acln0 acln0 restored the rand-read branch July 13, 2018 21:54
@acln0 acln0 deleted the rand-read branch July 13, 2018 21:54
@theckman theckman removed the blocked This PR is blocked on another issue or PR label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acln0 @theckman