fix package URLs in README.md #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, we should also update the minimum supported version of Go from 1.2 to 1.3 |
|
@CameronAckermanSEL done |
theckman
requested changes
Jul 13, 2018
README.md
Outdated
|
|
||
| ## Requirements | ||
|
|
||
| UUID package requires Go >= 1.2. | ||
| UUID package requires Go >= 1.3. |
There was a problem hiding this comment.
I don't think this is technically true. We stopped testing 1.2 because of our wanting to continue using coveralls.io, I'm not sure anything in the library itself is broken with < Go 1.2. Admittedly, because there is no context provided in da9da74 someone may not know why we dropped Go 1.2 support.
We could maybe rephrase this to be more correct, in that this library is only tested against Go 1.3+.
|
@theckman I have made the requested changes |
|
The travis ci error was a temporary travis-side error. if you really want you can restart the job. |
theckman
approved these changes
Jul 14, 2018
theckman
added a commit
that referenced
this pull request
Jul 14, 2018
fix package URLs in README.md Signed-off-by: Tim Heckman <t@heckman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1 i think