Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gdb Order #1520

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Fix gdb Order #1520

merged 1 commit into from
Mar 9, 2022

Conversation

FlyingBlazer
Copy link
Contributor

if model.orderBy != "" {
    model.orderBy += ","
}

既然前边已经有了这样的判断,说明Order方法本意是允许多次调用.OrderDesc("a").OrderDesc("b")来生成类似于order by a desc, b desc这样的查询语句的,所以这里应该使用+=而不是=

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1520 (47cefbf) into master (99455e3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   69.79%   69.78%   -0.01%     
==========================================
  Files         438      438              
  Lines       42421    42421              
==========================================
- Hits        29609    29605       -4     
- Misses      10917    10920       +3     
- Partials     1895     1896       +1     
Flag Coverage Δ
go-1.15 69.75% <100.00%> (+0.03%) ⬆️
go-1.16 69.75% <100.00%> (-0.03%) ⬇️
go-1.17 69.72% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_model_order_group.go 47.05% <100.00%> (-8.83%) ⬇️
os/glog/glog_logger_rotate.go 65.85% <0.00%> (-1.47%) ⬇️
net/gtcp/gtcp_conn.go 31.15% <0.00%> (-0.51%) ⬇️
os/gmutex/gmutex.go 97.36% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99455e3...47cefbf. Read the comment docs.

@gqcn gqcn merged commit 61db7d9 into gogf:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants