Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - clickhouse driver #1616

Merged
merged 19 commits into from
Apr 12, 2022
Merged

Feature - clickhouse driver #1616

merged 19 commits into from
Apr 12, 2022

Conversation

DGuang21
Copy link
Member

No description provided.

@gqcn gqcn added the wip label Feb 22, 2022
@gqcn
Copy link
Member

gqcn commented Feb 22, 2022

@DGuang21 The CI failed, please have a check.

database/gdb/gdb.go Outdated Show resolved Hide resolved
database/gdb/gdb_core_config.go Outdated Show resolved Hide resolved
database/gdb/gdb.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #1616 (c90a9d4) into master (66803fd) will increase coverage by 0.01%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master    #1616      +/-   ##
==========================================
+ Coverage   71.24%   71.25%   +0.01%     
==========================================
  Files         452      452              
  Lines       43310    43348      +38     
==========================================
+ Hits        30856    30888      +32     
- Misses      10477    10483       +6     
  Partials     1977     1977              
Flag Coverage Δ
go-1.15 71.23% <23.07%> (-0.02%) ⬇️
go-1.16 71.22% <23.07%> (?)
go-1.17 71.20% <23.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_core_ctx.go 56.00% <16.66%> (-36.31%) ⬇️
database/gdb/gdb_core_underlying.go 75.78% <100.00%> (ø)
os/gspath/gspath_cache.go 84.21% <0.00%> (ø)
os/glog/glog_logger_rotate.go 67.31% <0.00%> (+1.46%) ⬆️
net/ghttp/ghttp_server_config.go 61.65% <0.00%> (+1.54%) ⬆️
net/ghttp/ghttp_server_graceful.go 60.73% <0.00%> (+2.84%) ⬆️
net/gtcp/gtcp_pool.go 38.63% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66803fd...c90a9d4. Read the comment docs.

@DGuang21 DGuang21 requested a review from gqcn February 23, 2022 15:10
return strings.Join(sqlSlice, " "), args, nil
}
}
return sql, args, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

虽然使用正则匹配方式进行替换效率比较高,但是比较严谨的还是使用SQL解析器来解析后替换。可以参考下develop分支中sqlparser的用法。

database/gdb/gdb_core_underlying.go Outdated Show resolved Hide resolved
contrib/drivers/clickhouse/clickhouse.go Show resolved Hide resolved
database/gdb/gdb_core_ctx.go Outdated Show resolved Hide resolved
database/gdb/gdb_core_ctx.go Show resolved Hide resolved
database/gdb/gdb_core_ctx.go Outdated Show resolved Hide resolved
contrib/drivers/clickhouse/clickhouse.go Outdated Show resolved Hide resolved
contrib/drivers/clickhouse/clickhouse.go Outdated Show resolved Hide resolved
@DGuang21 DGuang21 requested a review from gqcn April 8, 2022 10:17
@gqcn gqcn merged commit edf40ba into gogf:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants