-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - clickhouse driver #1616
Conversation
@DGuang21 The CI failed, please have a check. |
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
+ Coverage 71.24% 71.25% +0.01%
==========================================
Files 452 452
Lines 43310 43348 +38
==========================================
+ Hits 30856 30888 +32
- Misses 10477 10483 +6
Partials 1977 1977
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
return strings.Join(sqlSlice, " "), args, nil | ||
} | ||
} | ||
return sql, args, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
虽然使用正则匹配方式进行替换效率比较高,但是比较严谨的还是使用SQL解析器来解析后替换。可以参考下develop
分支中sqlparser
的用法。
No description provided.