Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix bug] the default value of r.get is invalid #1659

Merged
merged 4 commits into from
Mar 11, 2022
Merged

[fix bug] the default value of r.get is invalid #1659

merged 4 commits into from
Mar 11, 2022

Conversation

arieslee
Copy link
Contributor

[fix bug] the default value of r.get is invalid
重跑ci

gqcn
gqcn requested changes Mar 10, 2022
View reviewed changes
net/ghttp/ghttp_request_param_request.go Outdated
value = r.GetRouter(key)
}
if value != nil {
if value.IsNil() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if !value.IsNil() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈哈哈哈，手误，刚才我自己也发现了

@gqcn gqcn merged commit 43992a1 into gogf:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arieslee @gqcn