-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom listener #1683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
- Coverage 71.44% 71.27% -0.17%
==========================================
Files 445 452 +7
Lines 42754 43336 +582
==========================================
+ Hits 30544 30888 +344
- Misses 10295 10471 +176
- Partials 1915 1977 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Macrow 感谢参与贡献!实现的想法不错,除了代码中CR注释,这里再提点要求:任何功能的新增都应当有单元测试,以保障逻辑正确及代码质量。这一点非常重要。 |
@gqcn 已经按照你的修改意见进行了调整,添加了单元测试。 另外对初始化listeners时做了一点点调整。使用端口作为listeners的key,以用来匹配替换rawListener。 |
@Macrow 同时,CI失败了,往往仅当CI成功后才会进入CR流程。 |
@gqcn 强哥有空帮忙看看ci错误在哪儿? |
Add SetListener method for supporting custom listeners.
另外有相关的issue
#1043