Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid a single space at the end of a line. #1735

Merged
merged 1 commit into from Apr 12, 2022
Merged

avoid a single space at the end of a line. #1735

merged 1 commit into from Apr 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2022

No description provided.

@gqcn
Copy link
Member

gqcn commented Apr 7, 2022

@yuancjun Would you please describe this update? Or take some examples?

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1735 (4ca1684) into master (52d8371) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
- Coverage   71.27%   71.26%   -0.01%     
==========================================
  Files         452      452              
  Lines       43310    43310              
==========================================
- Hits        30869    30865       -4     
- Misses      10466    10469       +3     
- Partials     1975     1976       +1     
Flag Coverage Δ
go-1.15 71.25% <100.00%> (+<0.01%) ⬆️
go-1.16 71.24% <100.00%> (+<0.01%) ⬆️
go-1.17 71.24% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/glog/glog_logger_handler.go 76.27% <100.00%> (ø)
net/gtcp/gtcp_pool.go 34.09% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d8371...4ca1684. Read the comment docs.

@ghost
Copy link
Author

ghost commented Apr 8, 2022

@yuancjun Would you please describe this update? Or take some examples?

@gqcn
This is a sample.
Note that there is a space at the end of the line here.

package main

import (
	"github.com/gogf/gf/v2/frame/g"
	"github.com/gogf/gf/v2/os/gctx"
)

func main() {
	ctx := gctx.New()

	g.Log().Print(ctx, "v1", "v2")
	// May Output:
	// 2022-04-08 11:07:24.400 {b0826ebff5cce31608c12e46a8e855af} v1 v2 
	// Expected Output:
	// 2022-04-08 11:07:24.400 {b0826ebff5cce31608c12e46a8e855af} v1 v2
}

@gqcn
Copy link
Member

gqcn commented Apr 12, 2022

@yuancjun I see, that's a good spot. You're meticulous.

@gqcn gqcn merged commit 5144cc0 into gogf:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants