Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for .properties configuration file #1806

Merged
merged 12 commits into from
May 13, 2022
Merged

Conversation

happyinsect
Copy link
Contributor

add support for .properties configuration file

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1806 (4902eb7) into master (c40a4d8) will decrease coverage by 0.00%.
The diff coverage is 83.89%.

@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
- Coverage   73.46%   73.46%   -0.01%     
==========================================
  Files         494      495       +1     
  Lines       44175    44292     +117     
==========================================
+ Hits        32455    32539      +84     
- Misses       9768     9792      +24     
- Partials     1952     1961       +9     
Flag Coverage Δ
go-1.15 73.46% <83.89%> (+0.04%) ⬆️
go-1.16 ?
go-1.17 73.43% <83.89%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
encoding/gjson/gjson.go 84.01% <ø> (ø)
encoding/gproperties/gproperties.go 81.31% <81.31%> (ø)
encoding/gjson/gjson_api_encoding.go 85.18% <83.33%> (-0.24%) ⬇️
encoding/gjson/gjson_api_new_load.go 96.63% <100.00%> (+0.21%) ⬆️
os/gspath/gspath_cache.go 87.71% <0.00%> (-7.02%) ⬇️
net/gtcp/gtcp_pool.go 34.09% <0.00%> (-4.55%) ⬇️
os/gfsnotify/gfsnotify_watcher.go 81.51% <0.00%> (-2.53%) ⬇️
os/glog/glog_logger_rotate.go 65.85% <0.00%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40a4d8...4902eb7. Read the comment docs.

encoding/gproperties/gproperties.go Show resolved Hide resolved
encoding/gproperties/gproperties.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@happyinsect happyinsect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user viper as the properties file decoder

encoding/gproperties/gproperties.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@gqcn gqcn merged commit 31bc30b into gogf:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants