Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix#1849 #1851

Merged
merged 1 commit into from
May 18, 2022
Merged

Bug fix#1849 #1851

merged 1 commit into from
May 18, 2022

Conversation

happyinsect
Copy link
Contributor

dataType := gfile.ExtName(usedFileName) usedFileName is always "config" and dataType is "",usedFileName should be filePath instead.

Add support for properties config file.

dataType := gfile.ExtName(usedFileName) usedFileName is always "config" and dataType is "",usedFileName should be filePath instead.

Add support for properties config file.
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1851 (6b61a1e) into master (0e2a007) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
+ Coverage   73.47%   73.49%   +0.01%     
==========================================
  Files         495      495              
  Lines       44292    44336      +44     
==========================================
+ Hits        32545    32584      +39     
- Misses       9787     9793       +6     
+ Partials     1960     1959       -1     
Flag Coverage Δ
go-1.15 73.47% <100.00%> (+0.02%) ⬆️
go-1.16 73.46% <100.00%> (+0.01%) ⬆️
go-1.17 73.48% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gcfg/gcfg_adapter_file.go 72.51% <100.00%> (ø)
os/gfsnotify/gfsnotify_watcher_loop.go 78.15% <0.00%> (-5.05%) ⬇️
net/gclient/gclient_response.go 72.22% <0.00%> (-3.46%) ⬇️
os/gcmd/gcmd_parser.go 92.90% <0.00%> (-2.59%) ⬇️
protocol/goai/goai_shema.go 70.92% <0.00%> (-2.08%) ⬇️
os/glog/glog_logger_rotate.go 65.85% <0.00%> (-1.47%) ⬇️
os/gcmd/gcmd_command_object.go 51.41% <0.00%> (-0.99%) ⬇️
os/gcmd/gcmd_command.go 100.00% <0.00%> (ø)
protocol/goai/goai_parameter_ref.go 80.70% <0.00%> (+0.34%) ⬆️
net/gtcp/gtcp_conn.go 31.65% <0.00%> (+0.50%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2a007...6b61a1e. Read the comment docs.

@gqcn gqcn merged commit 57941b6 into gogf:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants