Feature/oracle #1869
Merged
Feature/oracle #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oracle driver can only run above go 1.17
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 73.24% 73.23% -0.02%
==========================================
Files 503 503
Lines 45392 45479 +87
==========================================
+ Hits 33249 33305 +56
- Misses 10116 10143 +27
- Partials 2027 2031 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gqcn
requested changes
May 23, 2022
contrib/drivers/mssql/mssql.go
Outdated
| fields[m["Field"].String()] = &gdb.TableField{ | ||
| Index: i, | ||
| Name: m["Field"].String(), | ||
| Type: m["Type"].String(), | ||
| Null: m["Null"].Bool(), | ||
| Null: isNull, |
contrib/drivers/oracle/oracle.go
Outdated
| if reflect.TypeOf(v).Kind() == reflect.String { | ||
| valueStr := gconv.String(v) | ||
| if gregex.IsMatchString(`^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$`, valueStr) { | ||
| // args[i] = fmt.Sprintf(`TO_DATE('%s','yyyy-MM-dd HH:MI:SS')`, valueStr) | ||
| args[i], _ = time.ParseInLocation("2006-01-02 15:04:05", valueStr, time.Local) | ||
| } | ||
| } | ||
| } | ||
| }*/ |
| Name: strings.ToLower(m["FIELD"].String()), | ||
| Type: strings.ToLower(m["TYPE"].String()), | ||
| Name: m["FIELD"].String(), | ||
| Type: m["TYPE"].String(), |
| gtest.AssertEQ(ok, true) | ||
|
|
||
| gtest.AssertEQ(res[k].Name, k) | ||
| gtest.Assert(res[k].Type, v) |
| func TestFilteredLink(t *testing.T) { | ||
| gtest.C(t, func(t *gtest.T) { | ||
| s := db.FilteredLink() | ||
| gtest.AssertEQ(s, "") |
There was a problem hiding this comment.
缺少Link配置，以便使得FilteredLink方法生效，这样才能返回结果，再执行断言。
| gtest.C(t, func(t *gtest.T) { | ||
| _, err := dbErr.Query(ctx, "select 1 from dual") | ||
| gtest.AssertNE(err, nil) | ||
| }) |
There was a problem hiding this comment.
对于FilteredLink方法的单例来讲，这两个SELECT的case似乎没什么意义？
| } | ||
| }) | ||
|
|
||
| } |
There was a problem hiding this comment.
这个只是个工具方法，并不是单测，并且不能和上面的单测原子执行。
写单测，需要保证单测的每个case结束完毕后，不会污染环境。
如果oracle有默认生成的日志文件的话，建议通过配置取消掉。
gqcn
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.更换oracle驱动
2. 增加oracle单元测试
3. 修改mssql单元测试
4. ci中增加oracle镜像，oracle driver只在1.17上执行