Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gsvc interface #1871

Merged
merged 12 commits into from
May 23, 2022
Merged

Feature/gsvc interface #1871

merged 12 commits into from
May 23, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented May 20, 2022

  1. Change struct implements gsvc.Service to interface gsvc.Service.
  2. Update contribution packages contrib/registry/etcd and contrib/registry/polaris for this change accordingly.

@gqcn gqcn requested a review from houseme May 20, 2022 08:25
@houseme houseme self-requested a review May 20, 2022 16:25
houseme and others added 7 commits May 21, 2022 21:28
* feat: upgrade etcd version and improve comments

* feat: improve code for test,Register return Service and error
* Feature/gsvc interface (#1872) (#4)

* feat: upgrade etcd version and improve comments

* feat: improve code for test,Register return Service and error

* go mod tidy
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #1871 (84d7972) into develop (6d0b4fa) will decrease coverage by 0.22%.
The diff coverage is 59.09%.

@@             Coverage Diff             @@
##           develop    #1871      +/-   ##
===========================================
- Coverage    73.46%   73.23%   -0.23%     
===========================================
  Files          494      506      +12     
  Lines        44175    45440    +1265     
===========================================
+ Hits         32451    33276     +825     
- Misses        9770    10142     +372     
- Partials      1954     2022      +68     
Flag Coverage Δ
go-1.15 ?
go-1.15-386 73.17% <59.09%> (?)
go-1.16 ?
go-1.16-amd64 73.16% <59.09%> (?)
go-1.17 ?
go-1.17-386 73.22% <59.09%> (?)
go-1.17-amd64 73.18% <59.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/mssql/mssql.go 85.83% <ø> (ø)
contrib/drivers/mysql/mysql.go 64.34% <ø> (ø)
contrib/drivers/pgsql/pgsql.go 11.11% <0.00%> (ø)
database/gdb/gdb.go 65.81% <ø> (+1.53%) ⬆️
encoding/gjson/gjson.go 84.01% <ø> (ø)
net/gclient/gclient_config.go 39.13% <0.00%> (ø)
net/gclient/gclient_response.go 72.22% <0.00%> (-3.46%) ⬇️
net/gclient/gclient_tracing.go 44.00% <ø> (ø)
net/gclient/gclient_tracing_tracer.go 0.00% <ø> (ø)
net/ghttp/ghttp.go 100.00% <ø> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a01275...84d7972. Read the comment docs.

@gqcn gqcn merged commit ab50626 into develop May 23, 2022
@gqcn gqcn deleted the feature/gsvc-interface branch May 27, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants