-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gsvc interface #1871
Merged
Merged
Feature/gsvc interface #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseme
approved these changes
May 20, 2022
* feat: upgrade etcd version and improve comments * feat: improve code for test,Register return Service and error
Codecov Report
@@ Coverage Diff @@
## develop #1871 +/- ##
===========================================
- Coverage 73.46% 73.23% -0.23%
===========================================
Files 494 506 +12
Lines 44175 45440 +1265
===========================================
+ Hits 32451 33276 +825
- Misses 9770 10142 +372
- Partials 1954 2022 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gsvc.Service
to interfacegsvc.Service
.contrib/registry/etcd
andcontrib/registry/polaris
for this change accordingly.