Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gf gen service ignore watch file dir windows platform bug #1889

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

ddpmz
Copy link
Contributor

@ddpmz ddpmz commented Jun 1, 2022

windows平台上运行 gf gen service 的bug
“in source path” 的bug,打印结果
srcFolderDir: internal\logic
in.SrcFolder: internal/logic
所以在使用if gstr.HasSuffix(srcFolderDir, in.SrcFolder) 判断时替换一下斜杠就可以了。

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #1889 (14f37d0) into master (0639bec) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   73.77%   73.77%   -0.01%     
==========================================
  Files         509      509              
  Lines       46013    46013              
==========================================
- Hits        33946    33945       -1     
- Misses      10019    10020       +1     
  Partials     2048     2048              
Flag Coverage Δ
go-1.15-386 73.68% <ø> (ø)
go-1.15-amd64 73.66% <ø> (-0.01%) ⬇️
go-1.16-386 73.65% <ø> (-0.01%) ⬇️
go-1.16-amd64 73.67% <ø> (+<0.01%) ⬆️
go-1.17-386 73.71% <ø> (-0.01%) ⬇️
go-1.17-amd64 73.69% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gfile/gfile_scan.go 82.22% <0.00%> (-7.78%) ⬇️
container/gmap/gmap_hash_str_any_map.go 92.59% <0.00%> (+1.01%) ⬆️
os/gfsnotify/gfsnotify_watcher.go 84.03% <0.00%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0639bec...14f37d0. Read the comment docs.

@gqcn gqcn merged commit 9e6e800 into gogf:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants