Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the code coverage of the garray,glist module #1908

Merged
merged 96 commits into from
Jun 15, 2022

Conversation

huangqian1985
Copy link
Member

issue: #1902

1.NewConn 2.NewConnTLS 3.NewConnKeyCrt
1. ExampleConn_SendWithTimeout
2. ExampleConn_RecvLine
3. ExampleConn_RecvTill
1. ExampleConn_SendRecv
2. ExampleConn_SendRecvWithTimeout
3. ExampleConn_SetDeadline
4. ExampleConn_SetReceiveBufferWait
1. Test_Package_Option_HeadSize4
2. Test_Package_Option_Error
1. ExampleGetFreePorts
2. ExampleSend
3. ExampleSendRecv
4. ExampleSendWithTimeout
5. ExampleSendRecvWithTimeout
6. ExampleMustGetFreePort
1. ExampleSendPkg
2. ExampleSendRecvPkg
3. ExampleSendPkgWithTimeout
4. ExampleSendRecvPkgWithTimeout
1. Test_Pool_Send
2. Test_Pool_Recv
3. Test_Pool_RecvLine
4. Test_Pool_RecvTill
5. Test_Pool_RecvWithTimeout
6. Test_Pool_SendWithTimeout
7. Test_Pool_SendRecvWithTimeout
1. ExampleGetServer
2. ExampleSetAddress
3. ExampleSetHandler
4. ExampleRun_NilHandle
@codecov-commenter
Copy link

Codecov Report

Merging #1908 (36e660f) into master (4f37aba) will increase coverage by 0.64%.
The diff coverage is n/a.

❗ Current head 36e660f differs from pull request most recent head abeaf67. Consider uploading reports for the commit abeaf67 to get more accurate results

@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
+ Coverage   74.45%   75.09%   +0.64%     
==========================================
  Files         510      510              
  Lines       46176    46176              
==========================================
+ Hits        34379    34676     +297     
+ Misses       9726     9465     -261     
+ Partials     2071     2035      -36     
Flag Coverage Δ
go-1.15-386 75.00% <ø> (+0.64%) ⬆️
go-1.15-amd64 74.96% <ø> (+0.58%) ⬆️
go-1.16-386 74.96% <ø> (+0.59%) ⬆️
go-1.16-amd64 74.98% <ø> (+0.63%) ⬆️
go-1.17-386 75.04% <ø> (+0.63%) ⬆️
go-1.17-amd64 75.03% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gfsnotify/gfsnotify_filefunc.go 74.02% <0.00%> (-3.90%) ⬇️
os/gfsnotify/gfsnotify_watcher.go 84.03% <0.00%> (+2.52%) ⬆️
container/glist/glist.go 74.66% <0.00%> (+3.50%) ⬆️
container/garray/garray_sorted_str.go 97.73% <0.00%> (+4.93%) ⬆️
container/garray/garray_normal_int.go 99.04% <0.00%> (+5.16%) ⬆️
container/garray/garray_normal_str.go 98.87% <0.00%> (+5.62%) ⬆️
container/garray/garray_normal_any.go 99.06% <0.00%> (+7.44%) ⬆️
container/garray/garray_sorted_any.go 96.49% <0.00%> (+7.58%) ⬆️
container/garray/garray_sorted_int.go 97.89% <0.00%> (+8.63%) ⬆️
contrib/registry/polaris/polaris_watcher.go 73.21% <0.00%> (+10.71%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f37aba...abeaf67. Read the comment docs.

@gqcn gqcn merged commit b0650f3 into gogf:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants