Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the code coverage of the gmap module #1910

Merged
merged 113 commits into from
Jun 20, 2022
Merged

Conversation

huangqian1985
Copy link
Member

issue:#1909

1.NewConn 2.NewConnTLS 3.NewConnKeyCrt
1. ExampleConn_SendWithTimeout
2. ExampleConn_RecvLine
3. ExampleConn_RecvTill
1. ExampleConn_SendRecv
2. ExampleConn_SendRecvWithTimeout
3. ExampleConn_SetDeadline
4. ExampleConn_SetReceiveBufferWait
1. Test_Package_Option_HeadSize4
2. Test_Package_Option_Error
1. ExampleGetFreePorts
2. ExampleSend
3. ExampleSendRecv
4. ExampleSendWithTimeout
5. ExampleSendRecvWithTimeout
6. ExampleMustGetFreePort
1. ExampleSendPkg
2. ExampleSendRecvPkg
3. ExampleSendPkgWithTimeout
4. ExampleSendRecvPkgWithTimeout
1. Test_Pool_Send
2. Test_Pool_Recv
3. Test_Pool_RecvLine
4. Test_Pool_RecvTill
5. Test_Pool_RecvWithTimeout
6. Test_Pool_SendWithTimeout
7. Test_Pool_SendRecvWithTimeout
1. ExampleGetServer
2. ExampleSetAddress
3. ExampleSetHandler
4. ExampleRun_NilHandle
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #1910 (0abb18c) into master (7957016) will increase coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
+ Coverage   75.06%   75.60%   +0.53%     
==========================================
  Files         510      511       +1     
  Lines       46176    46197      +21     
==========================================
+ Hits        34664    34926     +262     
+ Misses       9476     9273     -203     
+ Partials     2036     1998      -38     
Flag Coverage Δ
go-1.15-386 75.49% <ø> (+0.49%) ⬆️
go-1.15-amd64 75.49% <ø> (+0.52%) ⬆️
go-1.16-386 75.49% <ø> (+0.50%) ⬆️
go-1.16-amd64 75.51% <ø> (+0.52%) ⬆️
go-1.17-386 75.55% <ø> (+0.51%) ⬆️
go-1.17-amd64 75.54% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
errors/gerror/gerror.go 81.59% <0.00%> (-0.98%) ⬇️
net/gclient/gclient.go 100.00% <0.00%> (ø)
net/gclient/gclient_chain.go 100.00% <0.00%> (ø)
net/gclient/gclient_request_obj.go 34.21% <0.00%> (ø)
net/gclient/gclient_request.go 72.72% <0.00%> (+0.90%) ⬆️
os/glog/glog_logger_rotate.go 67.31% <0.00%> (+1.46%) ⬆️
os/gfpool/gfpool_file.go 76.19% <0.00%> (+4.76%) ⬆️
net/ghttp/ghttp_response_write.go 37.86% <0.00%> (+4.81%) ⬆️
net/ghttp/ghttp_server_openapi.go 81.25% <0.00%> (+4.93%) ⬆️
container/gmap/gmap_list_map.go 90.86% <0.00%> (+4.96%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7957016...0abb18c. Read the comment docs.

@gqcn
Copy link
Member

gqcn commented Jun 15, 2022

@huangqian1985 请解决文件冲突。

.github/workflows/gf.yml Outdated Show resolved Hide resolved
@gqcn gqcn added the wip label Jun 16, 2022
@gqcn gqcn merged commit 3ae23df into gogf:master Jun 20, 2022
houseme pushed a commit to houseme/gf that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants