Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cluster mode and tls configuration support for package gredis #2936

Merged
merged 1 commit into from Sep 5, 2023

Conversation

joy999
Copy link
Contributor

@joy999 joy999 commented Sep 5, 2023

  1. tls及tlsSkipVerify配置不生效
  2. 在使用aws这类单endpoint的集群时,会错误地判定为单节点服务。故添加cluster配置项用于强行指定为集群服务。

2. add redis's config 'cluster'
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 75.92% and project coverage change: -0.06% ⚠️

Comparison is base (74bf1b4) 79.15% compared to head (de92dae) 79.09%.
Report is 7 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
- Coverage   79.15%   79.09%   -0.06%     
==========================================
  Files         638      639       +1     
  Lines       52570    52612      +42     
==========================================
+ Hits        41611    41616       +5     
- Misses       8892     8925      +33     
- Partials     2067     2071       +4     
Flag Coverage Δ
go-1.18-386 ?
go-1.18-amd64 ?
go-1.19-386 79.07% <75.92%> (-0.03%) ⬇️
go-1.19-amd64 79.05% <75.92%> (-0.06%) ⬇️
go-1.20-386 ?
go-1.20-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
container/gmap/gmap_hash_str_any_map.go 97.30% <ø> (-0.90%) ⬇️
contrib/nosql/redis/redis.go 83.90% <0.00%> (-5.12%) ⬇️
database/gdb/gdb.go 68.34% <ø> (ø)
database/gdb/gdb_result.go 36.00% <ø> (+3.85%) ⬆️
database/gredis/gredis_config.go 77.41% <ø> (ø)
internal/instance/instance.go 100.00% <ø> (ø)
os/gcache/gcache.go 96.77% <ø> (ø)
os/gtime/gtime.go 86.93% <ø> (ø)
text/gregex/gregex_cache.go 100.00% <ø> (ø)
text/gstr/gstr_slashes.go 100.00% <ø> (ø)
... and 22 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn changed the title 修复redis配置相关问题 add cluster mode and tls configuration support for package gredis Sep 5, 2023
@gqcn gqcn merged commit 912316d into master Sep 5, 2023
9 checks passed
@gqcn gqcn deleted the fix_redis_tls_cluster branch September 5, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants