Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Preserve original file permissions & Default copy permissions c… #2969

Merged
merged 3 commits into from Sep 19, 2023

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Sep 15, 2023

  1. DefaultPermCopy permissions changed to 755, 777 permission is too great;
  2. CopyOption adds an option to copy source file permissions;
  3. Added unit tests related to CopyOption.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (ef1e18d) 79.10% compared to head (c2f3fcb) 79.10%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   79.10%   79.10%   -0.01%     
==========================================
  Files         643      643              
  Lines       52749    52760      +11     
==========================================
+ Hits        41727    41735       +8     
- Misses       8942     8944       +2     
- Partials     2080     2081       +1     
Flag Coverage Δ
go-1.18-386 79.15% <50.00%> (+0.01%) ⬆️
go-1.18-amd64 79.15% <50.00%> (+<0.01%) ⬆️
go-1.19-386 79.03% <50.00%> (-0.03%) ⬇️
go-1.19-amd64 79.02% <50.00%> (-0.02%) ⬇️
go-1.20-386 79.11% <50.00%> (-0.04%) ⬇️
go-1.20-amd64 79.15% <50.00%> (+0.07%) ⬆️
go-1.21-386 ?
go-1.21-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
os/gfile/gfile.go 83.62% <ø> (ø)
os/gfile/gfile_copy.go 44.13% <50.00%> (+1.93%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

os/gfile/gfile_copy.go Outdated Show resolved Hide resolved
@gqcn gqcn merged commit 7c9eefe into gogf:master Sep 19, 2023
12 checks passed
@wlynxg wlynxg deleted the fix/gfile branch September 20, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants