Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve comment of router feature for ghttp.Server #3014

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Oct 11, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3cd0059) 77.65% compared to head (6bb6246) 77.64%.
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
- Coverage   77.65%   77.64%   -0.01%     
==========================================
  Files         647      647              
  Lines       54666    54706      +40     
==========================================
+ Hits        42449    42476      +27     
- Misses      10059    10075      +16     
+ Partials     2158     2155       -3     
Flag Coverage Δ
go-1.18-386 77.64% <92.30%> (-0.02%) ⬇️
go-1.18-amd64 77.60% <92.30%> (-0.05%) ⬇️
go-1.19-386 77.60% <92.30%> (+0.04%) ⬆️
go-1.19-amd64 77.61% <92.30%> (-0.01%) ⬇️
go-1.20-386 77.64% <92.30%> (+0.05%) ⬆️
go-1.20-amd64 77.60% <92.30%> (-0.02%) ⬇️
go-1.21-386 77.58% <92.30%> (?)
go-1.21-amd64 77.60% <92.30%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
net/ghttp/ghttp.go 50.00% <ø> (ø)
net/ghttp/ghttp_server_router_serve.go 71.02% <100.00%> (-5.90%) ⬇️
net/ghttp/ghttp_server_router.go 68.61% <0.00%> (-1.56%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit f464f30 into master Oct 16, 2023
12 checks passed
@gqcn gqcn deleted the enhance/router-comment branch October 16, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants