Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SetNoUrlEncode/NoUrlEncode functions for gclient.Client #3041

Merged
merged 1 commit into from
Oct 17, 2023
Merged

add SetNoUrlEncode/NoUrlEncode functions for gclient.Client #3041

merged 1 commit into from
Oct 17, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Oct 12, 2023

No description provided.

@gqcn gqcn changed the title add SetNoUrlEncode/NoUrlEncode functions for gclient.Client add SetNoUrlEncode/NoUrlEncode functions for gclient.Client Oct 12, 2023
houseme
houseme reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noUrlEncode=> urlEncode

是不是直接这样就可以了，如果为true,则对参数进行URL编码,如果为false,则不编码

@gqcn
Copy link
Member Author

gqcn commented Oct 16, 2023

noUrlEncode=> urlEncode

是不是直接这样就可以了，如果为true,则对参数进行URL编码,如果为false,则不编码

主要是这里默认值是urlencode，所以属性和参数、方法都是NoUrlEncode。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

noUrlEncode=> urlEncode

Can this be done directly? If it is true, the parameters will be URL encoded. If it is false, it will not be encoded.

The main reason is that the default value here is urlencode, so the attributes, parameters and methods are all NoUrlEncode.

@gqcn
Copy link
Member Author

gqcn commented Oct 17, 2023

@houseme Please approve this pr if this is ok for you.

@gqcn gqcn merged commit bb9cd37 into master Oct 17, 2023
24 checks passed
@gqcn gqcn deleted the feature/gclient-nourlencode branch October 17, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseme houseme houseme approved these changes

@huangqian1985 huangqian1985 Awaiting requested review from huangqian1985

@DGuang21 DGuang21 Awaiting requested review from DGuang21

@hailaz hailaz Awaiting requested review from hailaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gqcn @Issues-translate-bot @houseme