fix yahoo finance url to make it work #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hiro51 ありがとうございます！！！嬉しいです. ひとつだけスーパー姑事を言うとコミット名の最初は大文字にするといいかもです〜 |
gogotanaka
added a commit
that referenced
this pull request
Jan 19, 2015
fix yahoo finance url to make it work
|
承知した！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
どういう gem か確認するためにざっと見てたら README.md の Yahoo Finance の URL が括弧も含まれてしまって、うまくサイトに飛べてなかったので、細かいけど修正しました。
あと、本格的な共同開発の経験がないので、いろいろ常識が抜けていると思うので、何か気になったらぜひ教えてください。branch の名前の付け方とか。