Add support to "approve" pull requests

[nicolai86]

This would help with code reviews since one could configure a repository to enforce PR approval by certain users. Also in corporate environments PRs sometimes need to be checked and approved before being merged, which is a feature eg gitlab offers.

We could implement a tiny version like this:

• opt in per repo
• also checkbox if new commits invalidate existing approvals
• every user /w write access can approve if enabled

However, we first should implement the line based commenting for this to be useful. See #1644

What do you think?

[unknwon]

Sounds good!

But for

sometimes need to be checked and approved before being merged,

I don't quite understand about this one.

[hhenkel]

I agree with @nicolai86 that this would be a useful feature in a corporate environment. Currently we are using gitblit with its ticket functionality. We have several repositories where people open up pull requrests (tickets) and someone else needs to review and approve the changes. Those review and voting could also be done via CI system like jenkins - if the test build is successfully the jenkins server votes (and comments) on the pull request so that it could be merged. To be able to do something like that, we have dependencies to the api/webhooks.

For a first implementation that @nicolai86 described I would love to see a simple voting system, maybe something similar to gitblit ticket reviews, but I'm also open to other systems.

[unknwon]

@hhenkel thanks your info!

From what I understand:

1. Collaborators(with write access) can vote up/down
2. In the future, CI or whatever service can be count as 1 vote up/down

Is this the mechanism you're talking about?

[nicolai86]

@unknwon plus, you can configure a repo that a pull request can only be merged when +1/+2 has been reached.

[unknwon]

I got the idea, thanks!

[joubertredrat]

+1
I like this

[haliphax]

I think even having Jenkins be able to comment on a pull request to say whether it was built successfully or not would be a huge feature to have. Then, I wouldn't have to manually build anything that's being sent as a PR to see if it breaks the build.

[doliver3]

Yes, this an important feature. Please add it.

[DarthMDev]

+100000000