Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal for replication NG(next generation) #40

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Add proposal for replication NG(next generation) #40

merged 3 commits into from
Jan 31, 2019

Conversation

steven-zou
Copy link
Contributor

Add proposal for replication NG(next generation)

Signed-off-by: Steven Zou szou@vmware.com

@steven-zou
Add proposal for replication NG(next generation)
12291a0 
Signed-off-by: Steven Zou <szou@vmware.com>
nlowe
nlowe reviewed Jan 11, 2019
View reviewed changes
Copy link
Contributor

@nlowe nlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Lots of questions / comments as the proposal is pretty large.

proposals/Content-Replication-ng.md Outdated Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Outdated Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Show resolved Hide resolved
proposals/Content-Replication-ng.md Outdated Show resolved Hide resolved
@lweitzman
Copy link

Screenshots of mockups attached and mockups of those images can be seen here: https://vmware.invisionapp.com/share/RKOJ1Q83XNS#/340549431_v1-8_-_Registries
image002
image003
image004
image005

@steven-zou
Copy link
Contributor Author

steven-zou commented Jan 15, 2019 •
edited
Loading

Screenshots of mockups attached and mockups of those images can be seen here: https://vmware.invisionapp.com/share/RKOJ1Q83XNS#/340549431_v1-8_-_Registries
image002
image003
image004
image005

@lweitzman

Thanks, Louis for the UI mockup. About the replication policy list view, I did not provide a mockup of replication policy list in this proposal, but it has some minor changes. More info columns should be included in the list view.

  • src registry
  • dest registry
  • src namespaces
  • dest namespaces

@steven-zou
Copy link
Contributor Author

@nlowe

Any other comments to the main process? if no, please approve the PR. Then we can start the work.

@reasonerjt reasonerjt mentioned this pull request Jan 15, 2019
Closed
reasonerjt
reasonerjt reviewed Jan 15, 2019
View reviewed changes
proposals/Content-Replication-ng.md
* Prepare the downstream registry replicating environment, most cases are creating corresponding namepsaces;
* Do other necessary actions if necessary.
* **Data Transferring**: Do the real data transfer action here. The data upstream and downstream are connected through an IO buffer to achieve the purpose of improving performance by reading and writing at the same time.
* **Post Action**: Do some clean work if needed or send notifications to the interested parts after the replication completed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't sending notification be covered in another proposal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, not confirmed. Here just list out some potential cases can be done in such a stage. We may not provide any functions here so far as discussed in the WG.

@nlowe
Copy link
Contributor

nlowe commented Jan 15, 2019

@steven-zou There are a few comments from my initial review (hidden behind the 19 more items) that'd I'd love your input on. I'll try to take another pass today and see if I missed anything.

@steven-zou steven-zou force-pushed the add_replication_ng_proposal branch 4 times, most recently from 7d22461 to 25fa26c Compare January 16, 2019 14:00
@steven-zou
Copy link
Contributor Author

@steven-zou There are a few comments from my initial review (hidden behind the 19 more items) that'd I'd love your input on. I'll try to take another pass today and see if I missed anything.

@nlowe I saw that and comments to your comments.

@steven-zou
Copy link
Contributor Author

Aggregate and link the previous PRs of replication related to this one:

#21
#26

@steven-zou steven-zou mentioned this pull request Jan 17, 2019
Closed
This was referenced Jan 23, 2019
Closed
Closed
Closed
Closed
@steven-zou
Add UI mock design for the replication NG
7d8da42 
Signed-off-by: Steven Zou <szou@vmware.com>
@steven-zou steven-zou merged commit 69ba01a into goharbor:master Jan 31, 2019
@steven-zou steven-zou deleted the add_replication_ng_proposal branch January 31, 2019 05:22
@ghost ghost mentioned this pull request Feb 1, 2019
Closed
@ghost ghost mentioned this pull request Feb 8, 2019
Closed
@steven-zou steven-zou added the status/accepted Proposal is accepted label Feb 16, 2019
@reasonerjt reasonerjt mentioned this pull request Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlowe nlowe nlowe left review comments

@reasonerjt reasonerjt reasonerjt left review comments

@ywk253100 ywk253100 ywk253100 left review comments

@mmpei mmpei mmpei left review comments

Assignees
No one assigned
Labels
area/replication kind/proposal status/accepted Proposal is accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@steven-zou @lweitzman @nlowe @reasonerjt @ywk253100 @mmpei