Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple domains #1706

Closed
wants to merge 1 commit into from

Conversation

nevlkv
Copy link

@nevlkv nevlkv commented Feb 14, 2024

Harbor may use multiple domains for registry and helm charts

https://registry.<fqdn>
https://helm-charts.<fqdn>

and we needed patching ingress for operate in this state

Signed-off-by: Nikolay Volkov <n.volkov@2gis.ru>
@nevlkv nevlkv force-pushed the add_multiple_fqdn_for_ingress branch from f857dd1 to 305fd81 Compare February 14, 2024 08:16
@Vad1mo
Copy link
Member

Vad1mo commented Feb 14, 2024

hey @nevlkv are you sure this is working, Did you try pulling and pushing from both domains not just logging in.

@nevlkv
Copy link
Author

nevlkv commented Feb 14, 2024

hey @nevlkv are you sure this is working, Did you try pulling and pushing from both domains not just logging in.

we have 2 instancies with aliases

ingress1:
registry.internal.domain 
registry.location1.internal.domain

ingress2:
registry.internal.domain
registry.location2.internal.domain
pull registry.internal.domain -> lb

lb  - > registry.location1.internal.domain
     \-> registry.location2.internal.domain

registry.locationN.internal.domain synced

also we use custom alias

helm-charts.internal.domain = CNAME => registry.internal.domain

@Vad1mo
Copy link
Member

Vad1mo commented Feb 22, 2024

@nevlkv there is an error in your PR, can you fix the code, take a look at the tests.

@zyyw
Copy link
Collaborator

zyyw commented Mar 7, 2024

why do we need multiple domains for registry and helm charts?
If the helm charts refers to chartmuseum chart, then it's been removed and not supported any more.
If the helm charts refers to oci-compliant artifact, then why we need to differentiate oci chart and oci images.
Closing it now.

@zyyw zyyw closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants