-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add artifact trash manager #10753
Merged
Merged
add artifact trash manager #10753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wy65701436
force-pushed
the
artifact-trash
branch
from
February 18, 2020 08:57
f95ebed
to
2ab37cd
Compare
ywk253100
reviewed
Feb 18, 2020
ywk253100
reviewed
Feb 18, 2020
ywk253100
reviewed
Feb 18, 2020
ywk253100
reviewed
Feb 18, 2020
ywk253100
reviewed
Feb 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #10753 +/- ##
==========================================
- Coverage 58.15% 58.1% -0.05%
==========================================
Files 779 782 +3
Lines 43565 43624 +59
Branches 1762 1762
==========================================
+ Hits 25334 25347 +13
- Misses 14925 14968 +43
- Partials 3306 3309 +3
Continue to review full report at Codecov.
|
wy65701436
force-pushed
the
artifact-trash
branch
6 times, most recently
from
February 18, 2020 11:18
f1f3ee5
to
0a700c8
Compare
ywk253100
reviewed
Feb 19, 2020
wy65701436
force-pushed
the
artifact-trash
branch
2 times, most recently
from
February 19, 2020 03:39
e90ab84
to
2e28b18
Compare
ywk253100
approved these changes
Feb 19, 2020
1, move the deleted artifact into trash 2, disable GC to delete the untagged manifest Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
force-pushed
the
artifact-trash
branch
from
February 19, 2020 06:53
90e1990
to
f160505
Compare
heww
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, move the deleted artifact into trash
2, disable GC to delete the untagged manifest
Signed-off-by: wang yan wangyan@vmware.com