Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add artifact trash manager #10753

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Feb 18, 2020

1, move the deleted artifact into trash
2, disable GC to delete the untagged manifest

Signed-off-by: wang yan wangyan@vmware.com

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #10753 into master will decrease coverage by 0.04%.
The diff coverage is 28.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10753      +/-   ##
==========================================
- Coverage   58.15%    58.1%   -0.05%     
==========================================
  Files         779      782       +3     
  Lines       43565    43624      +59     
  Branches     1762     1762              
==========================================
+ Hits        25334    25347      +13     
- Misses      14925    14968      +43     
- Partials     3306     3309       +3
Impacted Files Coverage Δ
src/pkg/artifact/dao/dao.go 76.92% <ø> (ø) ⬆️
src/registryctl/api/registry.go 0% <0%> (ø) ⬆️
src/pkg/artifactrash/model/model.go 100% <100%> (ø)
src/pkg/artifactrash/manager.go 33.33% <33.33%> (ø)
src/pkg/artifactrash/dao/dao.go 5.88% <5.88%> (ø)
src/api/artifact/controller.go 66.9% <66.66%> (-0.02%) ⬇️
src/replication/registry/healthcheck.go 45.83% <0%> (-8.34%) ⬇️
...ortal/src/lib/components/config/gc/gc.component.ts 62.06% <0%> (-3.45%) ⬇️
... and 513 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad02de...f160505. Read the comment docs.

@wy65701436 wy65701436 force-pushed the artifact-trash branch 6 times, most recently from f1f3ee5 to 0a700c8 Compare February 18, 2020 11:18
@wy65701436 wy65701436 force-pushed the artifact-trash branch 2 times, most recently from e90ab84 to 2e28b18 Compare February 19, 2020 03:39
1, move the deleted artifact into trash
2, disable GC to delete the untagged manifest

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 merged commit 22021a9 into goharbor:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants