-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resovle the system artifact schedule issue #17098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17098 +/- ##
==========================================
- Coverage 67.05% 67.04% -0.02%
==========================================
Files 980 980
Lines 82310 82310
Branches 2630 2630
==========================================
- Hits 55194 55183 -11
- Misses 23324 23332 +8
- Partials 3792 3795 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
added
release-note/ignore-for-release
Do not include PR or Issue for release notes
target/2.6.0
labels
Jun 29, 2022
ywk253100
approved these changes
Jun 30, 2022
Please fix the title! Thank you! |
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice. Signed-off-by: Wang Yan <wangyan@vmware.com>
chlins
reviewed
Jun 30, 2022
chlins
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice. Signed-off-by: Wang Yan <wangyan@vmware.com>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice. Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice.
Signed-off-by: Wang Yan wangyan@vmware.com
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(17008)
Please indicate you've done the following: