Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resovle the system artifact schedule issue #17098

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jun 29, 2022

Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice.

Signed-off-by: Wang Yan wangyan@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(17008)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner June 29, 2022 10:52
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #17098 (6e66413) into main (79d149b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17098      +/-   ##
==========================================
- Coverage   67.05%   67.04%   -0.02%     
==========================================
  Files         980      980              
  Lines       82310    82310              
  Branches     2630     2630              
==========================================
- Hits        55194    55183      -11     
- Misses      23324    23332       +8     
- Partials     3792     3795       +3     
Flag Coverage Δ
unittests 67.04% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/permission/evaluator/rbac/casbin_match.go 90.00% <0.00%> (-10.00%) ⬇️
src/lib/cache/helper.go 73.91% <0.00%> (-8.70%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.76% <0.00%> (-5.56%) ⬇️
src/jobservice/runner/redis.go 63.15% <0.00%> (-5.27%) ⬇️
src/controller/event/topic.go 10.81% <0.00%> (+1.80%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (+4.44%) ⬆️
...audit-log-purge/history/purge-history.component.ts 45.97% <0.00%> (+5.74%) ⬆️

@wy65701436 wy65701436 added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.6.0 labels Jun 29, 2022
@OrlinVasilev
Copy link
Member

Please fix the title! Thank you!

Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice.

Signed-off-by: Wang Yan <wangyan@vmware.com>
@wy65701436 wy65701436 changed the title fix 17008 Resovle the system artifact schedule issue Jun 30, 2022
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 94bf1c0 into goharbor:main Jul 1, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice.

Signed-off-by: Wang Yan <wangyan@vmware.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice.

Signed-off-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants