Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support searching artifacts by specified tag name #18175

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Feb 6, 2023

1.Fixes #18082
2.Update CSS

Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #18175 (fdf9347) into main (fdf9347) will not change coverage.
The diff coverage is n/a.

❗ Current head fdf9347 differs from pull request most recent head 0f34a29. Consider uploading reports for the commit 0f34a29 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18175   +/-   ##
=======================================
  Coverage   43.86%   43.86%           
=======================================
  Files         245      245           
  Lines       13400    13400           
  Branches     2676     2676           
=======================================
  Hits         5878     5878           
  Misses       7234     7234           
  Partials      288      288           
Flag Coverage Δ
unittests 43.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  1.Fixes goharbor#18082
  2.Update CSS

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 9d30955 into goharbor:main Feb 8, 2023
tpoxa pushed a commit to container-registry/harbor that referenced this pull request Feb 8, 2023
1.Fixes goharbor#18082
  2.Update CSS

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Maksym <maksym@container-registry.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
1.Fixes goharbor#18082
  2.Update CSS

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
1.Fixes goharbor#18082
  2.Update CSS

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing deleted the tag-search branch March 29, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot filter artifacts in the web UI
5 participants