Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add Job Service Dashboard Schedules testcase #18556

Conversation

YangJiao0817
Copy link
Member

Fix #17949

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#17949

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Apr 19, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner April 19, 2023 08:49
@YangJiao0817 YangJiao0817 self-assigned this Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #18556 (89cdbfd) into release-2.7.0 (0d6633e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #18556      +/-   ##
=================================================
- Coverage          66.40%   66.39%   -0.02%     
=================================================
  Files               1012     1012              
  Lines             108614   108614              
  Branches            2677     2677              
=================================================
- Hits               72128    72112      -16     
- Misses             32526    32539      +13     
- Partials            3960     3963       +3     
Flag Coverage Δ
unittests 66.39% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@YangJiao0817 YangJiao0817 merged commit 35047cf into goharbor:release-2.7.0 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants