Use subtle.ConstantTimeCompare instead of compare directly #18697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18697 +/- ##
==========================================
+ Coverage 67.36% 67.37% +0.01%
==========================================
Files 980 980
Lines 106749 106749
Branches 2668 2668
==========================================
+ Hits 71914 71927 +13
+ Misses 30976 30954 -22
- Partials 3859 3868 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
force-pushed
the
23may18_verify_auth
branch
from
b43c38a
to
1fc09e5
Compare
Vad1mo
approved these changes
May 19, 2023
Signed-off-by: stonezdj <daojunz@vmware.com>
stonezdj
force-pushed
the
23may18_verify_auth
branch
from
1fc09e5
to
343d571
Compare
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
…18697) Signed-off-by: stonezdj <daojunz@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
…18697) Signed-off-by: stonezdj <daojunz@vmware.com>
kycheng
pushed a commit
to alauda/harbor
that referenced
this pull request
Jun 14, 2024
…18697) Signed-off-by: stonezdj <daojunz@vmware.com>
kycheng
pushed a commit
to alauda/harbor
that referenced
this pull request
Jun 14, 2024
…18697) Signed-off-by: stonezdj <daojunz@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: