Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go1.20.7 on release-1.10.0 base on ph4 #19206

Merged

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #19206 (97de32f) into release-1.10.0 (31547ec) will decrease coverage by 5.96%.
The diff coverage is n/a.

❗ Current head 97de32f differs from pull request most recent head ec3d10e. Consider uploading reports for the commit ec3d10e to get more accurate results

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #19206      +/-   ##
==================================================
- Coverage           55.99%   50.04%   -5.96%     
==================================================
  Files                 612      155     -457     
  Lines               32467     6322   -26145     
  Branches              825      825              
==================================================
- Hits                18181     3164   -15017     
+ Misses              11487     2923    -8564     
+ Partials             2799      235    -2564     
Flag Coverage Δ
unittests 50.04% <ø> (-5.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 457 files with indirect coverage changes

@MinerYang MinerYang force-pushed the bump_go1.20.7_release-1.10.0 branch 3 times, most recently from fb502b0 to 83521e2 Compare August 17, 2023 06:16
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: yminer <yminer@vmware.com>

add GOFLAGS=-buildvcs=false

upadate GO111MODULE=auto

Signed-off-by: yminer <yminer@vmware.com>

update ut_install set +e

fix gofmt

Signed-off-by: yminer <yminer@vmware.com>

update ut_run.sh
@MinerYang MinerYang merged commit 1788f8b into goharbor:release-1.10.0 Aug 17, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants