Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Use batch to list the job id in the job queue to avoid crash redis #19455

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 17, 2023

fixes: #19436

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes: goharbor#19436

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner October 17, 2023 02:36
@stonezdj stonezdj assigned wy65701436 and chlins and unassigned Vad1mo, zyyw and OrlinVasilev Oct 17, 2023
@stonezdj stonezdj added the release-note/update Update or Fix label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #19455 (4a89265) into release-2.9.0 (6f85d59) will increase coverage by 0.01%.
Report is 5 commits behind head on release-2.9.0.
The diff coverage is 57.89%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19455      +/-   ##
=================================================
+ Coverage          67.38%   67.39%   +0.01%     
=================================================
  Files                993      993              
  Lines             108921   108932      +11     
  Branches            2752     2752              
=================================================
+ Hits               73396    73420      +24     
+ Misses             31580    31556      -24     
- Partials            3945     3956      +11     
Flag Coverage Δ
unittests 67.39% <57.89%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/jobmonitor/redis.go 44.11% <57.89%> (+26.53%) ⬆️

... and 7 files with indirect coverage changes

@stonezdj stonezdj changed the title Use batch to list the job id in the job queue to avoid crash redis [cherry-pick] Use batch to list the job id in the job queue to avoid crash redis Oct 17, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) October 17, 2023 03:18
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 40f8217 into goharbor:release-2.9.0 Oct 18, 2023
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants