Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add GC accessory UI test case #19471

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Oct 20, 2023

Fix #19274

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#19274

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 force-pushed the add-gc-accessory-ui-testcase-2.9 branch from c81fbf0 to d23b54d Compare October 20, 2023 09:11
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #19471 (d23b54d) into release-2.9.0 (86c8dc5) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19471      +/-   ##
=================================================
- Coverage          67.44%   67.40%   -0.04%     
=================================================
  Files                993      993              
  Lines             108932   108932              
  Branches            2752     2752              
=================================================
- Hits               73471    73431      -40     
- Misses             31509    31551      +42     
+ Partials            3952     3950       -2     
Flag Coverage Δ
unittests 67.40% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) October 23, 2023 02:55
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 7905114 into goharbor:release-2.9.0 Oct 23, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants