Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update doublestar dep #20443

Merged
merged 2 commits into from
May 20, 2024
Merged

fix: update doublestar dep #20443

merged 2 commits into from
May 20, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented May 17, 2024 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20436

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fix: update doublestar dep
7c4ae95 
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw requested a review from a team as a code owner May 17, 2024 07:55
update api_common_install.sh
79bb377 
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
chlins
chlins approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wy65701436
wy65701436 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 64e4c85 into goharbor:release-2.9.0 May 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@Vad1mo Vad1mo

@stonezdj stonezdj

@wy65701436 wy65701436

@AllForNothing AllForNothing

@MinerYang MinerYang

Labels
release-note/update Update or Fix target/2.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zyyw @wy65701436 @chlins @Vad1mo @stonezdj @AllForNothing @MinerYang