Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: delete duplicate error check in artifacttrash dao #20557

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 6, 2024

Delete duplicate error check section in the artifacttrash dao Flush method.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner June 6, 2024 06:07
@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.31%. Comparing base (b7b8847) to head (32fa6fa).
Report is 218 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20557       +/-   ##
===========================================
- Coverage   67.56%   46.31%   -21.25%     
===========================================
  Files         991      247      -744     
  Lines      109181    13777    -95404     
  Branches     2719     2845      +126     
===========================================
- Hits        73768     6381    -67387     
+ Misses      31449     7067    -24382     
+ Partials     3964      329     -3635     
Flag Coverage Δ
unittests 46.31% <ø> (-21.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@chlins chlins enabled auto-merge (squash) June 11, 2024 03:59
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the style/remove-useless-err-check branch from ce1f572 to 32fa6fa Compare June 12, 2024 09:41
@chlins chlins merged commit 6a38ed3 into goharbor:main Jun 12, 2024
11 of 12 checks passed
mohamedawnallah pushed a commit to mohamedawnallah/harbor that referenced this pull request Jul 2, 2024
)

Signed-off-by: chlins <chlins.zhang@gmail.com>
mohamedawnallah pushed a commit to mohamedawnallah/harbor that referenced this pull request Jul 2, 2024
)

Signed-off-by: chlins <chlins.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants